Linux Kernels

PKCS#7: fix missing break on OID_sha224 case

This change “PKCS#7: fix missing break on OID_sha224 case” (commit 06af9b0) in Linux kernel is authored by Colin Ian King <colin.king [at] canonical.com> on Fri Mar 18 15:51:31 2016 +0000.

Description of "PKCS#7: fix missing break on OID_sha224 case"

The change “PKCS#7: fix missing break on OID_sha224 case” introduces changes as follows.

PKCS#7: fix missing break on OID_sha224 case

The OID_sha224 case is missing a break and it falls through
to the -ENOPKG error default.  Since HASH_ALGO_SHA224 seems
to be supported, this looks like an unintentional missing break.

Fixes: 07f081fb5057 ("PKCS#7: Add OIDs for sha224, sha284 and sha512 hash algos and use them")
Cc: <stable@vger.kernel.org> # 4.2+
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

Linux kernel releases containing commit 06af9b0

The Linux kernel releases containing this commit are as follows.

Linux kernel code changes from "PKCS#7: fix missing break on OID_sha224 case"

There is one line of Linux source code added/deleted in this change. Code changes to Linux kernel are as follows.

 crypto/asymmetric_keys/pkcs7_parser.c | 1 +
 1 file changed, 1 insertion(+)
 
diff --git a/crypto/asymmetric_keys/pkcs7_parser.c b/crypto/asymmetric_keys/pkcs7_parser.c
index 40de03f49ff8..bdd0d753ce5d 100644
--- a/crypto/asymmetric_keys/pkcs7_parser.c
+++ b/crypto/asymmetric_keys/pkcs7_parser.c
@@ -237,6 +237,7 @@ int pkcs7_sig_note_digest_algo(void *context, size_t hdrlen,
 		break;
 	case OID_sha224:
 		ctx->sinfo->sig.hash_algo = "sha224";
+		break;
 	default:
 		printk("Unsupported digest algo: %u\n", ctx->last_oid);
 		return -ENOPKG;

The commit for this change in Linux stable tree is 06af9b0 (patch).

Last modified: 2020/01/11 09:26