ALSA: hda/tegra: remove redundant clock enable API

This change “ALSA: hda/tegra: remove redundant clock enable API” in Linux kernel is authored by Sameer Pujar <spujar [at] nvidia.com> on Tue Jan 22 13:03:19 2019 +0530.

ALSA: hda/tegra: remove redundant clock enable API

Explicit clock enable is not required during probe, as this would be
managed by runtime PM calls. Clock can be enabled/disabled in runtime
resume/suspend. This way it is easier to balance clock enable/disable
counts.

Signed-off-by: Sameer Pujar <spujar@nvidia.com>
Reviewed-by: Ravindra Lokhande <rlokhande@nvidia.com>
Reviewed-by: Mohan Kumar D <mkumard@nvidia.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>

This Linux change may have been applied to various maintained Linux releases and you can find Linux releases including commit 091aa42.

There are 7 lines of Linux source code added/deleted in this change. Code changes to Linux kernel are as follows.

 sound/pci/hda/hda_tegra.c | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/sound/pci/hda/hda_tegra.c b/sound/pci/hda/hda_tegra.c
index 1189f97..f068b1e 100644
--- a/sound/pci/hda/hda_tegra.c
+++ b/sound/pci/hda/hda_tegra.c
@@ -319,7 +319,6 @@ static int hda_tegra_init_chip(struct azx *chip, struct platform_device *pdev)
 	struct hdac_bus *bus = azx_bus(chip);
 	struct device *dev = hda->dev;
 	struct resource *res;
-	int err;
 
 	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
 	hda->regs = devm_ioremap_resource(dev, res);
@@ -329,12 +328,6 @@ static int hda_tegra_init_chip(struct azx *chip, struct platform_device *pdev)
 	bus->remap_addr = hda->regs + HDA_BAR0;
 	bus->addr = res->start + HDA_BAR0;
 
-	err = hda_tegra_enable_clocks(hda);
-	if (err) {
-		dev_err(dev, "failed to get enable clocksn");
-		return err;
-	}
-
 	hda_tegra_init(hda);
 
 	return 0;

The commit for this change in Linux stable tree is 091aa42 (patch).

Leave a Reply

Your email address will not be published. Required fields are marked *