media: tvp5150: fix switch exit in set control handler

This change “media: tvp5150: fix switch exit in set control handler” in Linux kernel is authored by Marco Felsch <m.felsch [at]> on Thu Jun 28 12:20:34 2018 -0400.

media: tvp5150: fix switch exit in set control handler

The function only consists of a single switch case block without a
default case. Unsupported control requests are indicated by the -EINVAL
return code trough the last return statement at the end of the function. So
exiting just the switch case block returns the -EINVAL error code but the
hue control is supported and a zero should be returned instead.

Replace the break by a 'return 0' to fix this behaviour.

Fixes: d183e4efcae8 ("[media] v4l: tvp5150: Add missing break in set
control handler")

Signed-off-by: Marco Felsch <>
Signed-off-by: Mauro Carvalho Chehab <>

This Linux change may have been applied to various maintained Linux releases and you can find Linux releases including commit 2d29bcc.

There are 2 lines of Linux source code added/deleted in this change. Code changes to Linux kernel are as follows.

 drivers/media/i2c/tvp5150.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/media/i2c/tvp5150.c b/drivers/media/i2c/tvp5150.c
index 7dda77a..0857f11 100644
--- a/drivers/media/i2c/tvp5150.c
+++ b/drivers/media/i2c/tvp5150.c
@@ -834,7 +834,7 @@ static int tvp5150_s_ctrl(struct v4l2_ctrl *ctrl)
 		return 0;
 	case V4L2_CID_HUE:
 		tvp5150_write(sd, TVP5150_HUE_CTL, ctrl->val);
-		break;
+		return 0;
 		decoder->enable = ctrl->val ? false : true;

The commit for this change in Linux stable tree is 2d29bcc (patch).

Leave a Reply

Your email address will not be published. Required fields are marked *