MIPS: Octeon: add missing of_node_put()

This change “MIPS: Octeon: add missing of_node_put()” in Linux kernel is authored by Nicholas Mc Guire <hofrat [at] osadl.org> on Sat Jun 16 09:06:33 2018 +0200.

MIPS: Octeon: add missing of_node_put()

The call to of_find_node_by_name returns a node pointer with refcount
incremented thus it must be explicitly decremented here after the last

Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>
Signed-off-by: Paul Burton <paul.burton@mips.com>
Patchwork: https://patchwork.linux-mips.org/patch/19558/
Cc: Ralf Baechle <ralf@linux-mips.org>
Cc: James Hogan <jhogan@kernel.org>
Cc: linux-mips@linux-mips.org
Cc: linux-kernel@vger.kernel.org

This Linux change may have been applied to various maintained Linux releases and you can find Linux releases including commit b125951.

There are 2 lines of Linux source code added/deleted in this change. Code changes to Linux kernel are as follows.

 arch/mips/cavium-octeon/octeon-platform.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/mips/cavium-octeon/octeon-platform.c b/arch/mips/cavium-octeon/octeon-platform.c
index 2940e9c..807cada 100644
--- a/arch/mips/cavium-octeon/octeon-platform.c
+++ b/arch/mips/cavium-octeon/octeon-platform.c
@@ -322,6 +322,7 @@ static int __init octeon_ehci_device_init(void)
 		return 0;
 	pd = of_find_device_by_node(ehci_node);
+	of_node_put(ehci_node);
 	if (!pd)
 		return 0;
@@ -384,6 +385,7 @@ static int __init octeon_ohci_device_init(void)
 		return 0;
 	pd = of_find_device_by_node(ohci_node);
+	of_node_put(ohci_node);
 	if (!pd)
 		return 0;

The commit for this change in Linux stable tree is b125951 (patch).

Leave a Reply

Your email address will not be published. Required fields are marked *