Linux Kernels

V4L/DVB (9439): Bug! SFRL nibble got swapped

This change “V4L/DVB (9439): Bug! SFRL nibble got swapped” (commit 1b792e0) in Linux kernel is authored by Manu Abraham <abraham.manu [at] gmail.com> on Fri Nov 9 17:33:26 2007 -0300.

Description of "V4L/DVB (9439): Bug! SFRL nibble got swapped"

The change “V4L/DVB (9439): Bug! SFRL nibble got swapped” introduces changes as follows.

V4L/DVB (9439): Bug! SFRL nibble got swapped

The Bug was found by Arvo Jarve <arvo@softshark.ee>

It was a wonder how it worked in the case with this bug,
STM verified this that this nibble was in fact insignificant
and can be ignored.

But still we need to fix all inconsistencies.

Signed-off-by: Manu Abraham <manu@linuxtv.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>

Linux kernel releases containing commit 1b792e0

The Linux kernel releases containing this commit are as follows.

Linux kernel code changes from "V4L/DVB (9439): Bug! SFRL nibble got swapped"

There are 2 lines of Linux source code added/deleted in this change. Code changes to Linux kernel are as follows.

 drivers/media/dvb/frontends/stb0899_algo.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
 
diff --git a/drivers/media/dvb/frontends/stb0899_algo.c b/drivers/media/dvb/frontends/stb0899_algo.c
index 2256fc70c85a..6913bebe7162 100644
--- a/drivers/media/dvb/frontends/stb0899_algo.c
+++ b/drivers/media/dvb/frontends/stb0899_algo.c
@@ -110,7 +110,7 @@ static u32 stb0899_set_srate(struct stb0899_state *state, u32 master_clk, u32 sr
 
 	sfr[0] = (tmp >> 12) & 0xff;
 	sfr[1] = (tmp >>  4) & 0xff;
-	sfr[2] =  tmp & 0x0f;
+	sfr[2] =  tmp & 0xf0;
 
 //	stb0899_write_regs(state, STB0899_SFRUPH, sfr_up, 3);
 	stb0899_write_regs(state, STB0899_SFRH, sfr, 3);

The commit for this change in Linux stable tree is 1b792e0 (patch).

Last modified: 2020/01/11 09:35