char: mxser, fix ISA board lookup [Linux 2.6.30]

This Linux kernel change "char: mxser, fix ISA board lookup" is included in the Linux 2.6.30 release. This change is authored by Peter Botha <peterb [at] goldcircle.co.za> on Tue Jun 9 17:16:32 2009 -0700. The commit for this change in Linux stable tree is 96050df (patch).

char: mxser, fix ISA board lookup

There's a bug in the mxser kernel module that still appears in the
2.6.29.4 kernel.

mxser_get_ISA_conf takes a ioaddress as its first argument, by passing the
not of the ioaddr, you're effectively passing 0 which means it won't be
able to talk to an ISA card.  I have tested this, and removing the !
fixes the problem.

Cc: "Peter Botha" <[email protected]>
Signed-off-by: Jiri Slaby <[email protected]>
Acked-by: Alan Cox <[email protected]>
Cc: <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>

There are 2 lines of Linux source code added/deleted in this change. Code changes to Linux kernel are as follows.

 drivers/char/mxser.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/char/mxser.c b/drivers/char/mxser.c
index a420e8d..13f8871 100644
--- a/drivers/char/mxser.c
+++ b/drivers/char/mxser.c
@@ -2711,7 +2711,7 @@ static int __init mxser_module_init(void)
            continue;

        brd = &mxser_boards[m];
-       retval = mxser_get_ISA_conf(!ioaddr[b], brd);
+       retval = mxser_get_ISA_conf(ioaddr[b], brd);
        if (retval <= 0) {
            brd->info = NULL;
            continue;

Leave a Reply

Your email address will not be published. Required fields are marked *