Linux Kernels

pinctrl: sunxi: Be sure to clamp return value

This change “pinctrl: sunxi: Be sure to clamp return value” (commit 39e24ac) in Linux kernel is authored by Linus Walleij <linus.walleij [at] linaro.org> on Mon Dec 21 16:40:27 2015 +0100.

Description of "pinctrl: sunxi: Be sure to clamp return value"

The change “pinctrl: sunxi: Be sure to clamp return value” introduces changes as follows.

pinctrl: sunxi: Be sure to clamp return value

As we want gpio_chip .get() calls to be able to return negative
error codes and propagate to drivers, we need to go over all
drivers and make sure their return values are clamped to [0,1].
We do this by using the ret = !!(val) design pattern.

Cc: Maxime Ripard <maxime.ripard@free-electrons.com>
Acked-by: Chen-Yu Tsai <wens@csie.org>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

Linux kernel releases containing commit 39e24ac

The Linux kernel releases containing this commit are as follows.

Linux kernel code changes from "pinctrl: sunxi: Be sure to clamp return value"

There are 2 lines of Linux source code added/deleted in this change. Code changes to Linux kernel are as follows.

 drivers/pinctrl/sunxi/pinctrl-sunxi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
 
diff --git a/drivers/pinctrl/sunxi/pinctrl-sunxi.c b/drivers/pinctrl/sunxi/pinctrl-sunxi.c
index a437e4f8628b..c53a2dbdb5cf 100644
--- a/drivers/pinctrl/sunxi/pinctrl-sunxi.c
+++ b/drivers/pinctrl/sunxi/pinctrl-sunxi.c
@@ -469,7 +469,7 @@ static int sunxi_pinctrl_gpio_get(struct gpio_chip *chip, unsigned offset)
 	if (set_mux)
 		sunxi_pmx_set(pctl->pctl_dev, offset, SUN4I_FUNC_IRQ);
 
-	return val;
+	return !!val;
 }
 
 static void sunxi_pinctrl_gpio_set(struct gpio_chip *chip,

The commit for this change in Linux stable tree is 39e24ac (patch).

Last modified: 2020/01/11 09:39