ocfs2: adjust minlen with discard_granularity in the FITRIM ioctl [Linux 3.14]

This Linux kernel change "ocfs2: adjust minlen with discard_granularity in the FITRIM ioctl" is included in the Linux 3.14 release. This change is authored by Jie Liu <jeff.liu [at] oracle.com> on Tue Jan 21 15:48:36 2014 -0800. The commit for this change in Linux stable tree is 1ba2212 (patch).

ocfs2: adjust minlen with discard_granularity in the FITRIM ioctl

Adjust minlen with discard_granularity for FITRIM ioctl(2) if the given
minimum size in bytes is less than it because, discard granularity is
used to tell us that the minimum size of extent that can be discarded by
the storage device.

This is inspired by ext4 commit 5c2ed62fd447 ("ext4: Adjust minlen with
discard_granularity in the FITRIM ioctl") from Lukas Czerner.

Signed-off-by: Jie Liu <jeff.liu@oracle.com>
Cc: Mark Fasheh <mfasheh@suse.com>
Cc: Joel Becker <jlbec@evilplan.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

There are 2 lines of Linux source code added/deleted in this change. Code changes to Linux kernel are as follows.

 fs/ocfs2/ioctl.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/fs/ocfs2/ioctl.c b/fs/ocfs2/ioctl.c
index 4de6a2a..8ca3c29 100644
--- a/fs/ocfs2/ioctl.c
+++ b/fs/ocfs2/ioctl.c
@@ -980,6 +980,8 @@ long ocfs2_ioctl(struct file *filp, unsigned int cmd, unsigned long arg)
        if (copy_from_user(&range, argp, sizeof(range)))
            return -EFAULT;

+       range.minlen = max_t(u64, q->limits.discard_granularity,
+                    range.minlen);
        ret = ocfs2_trim_fs(sb, &range);
        if (ret < 0)
            return ret;

Leave a Reply

Your email address will not be published. Required fields are marked *