GFS2: return -E2BIG if hit the maximum limits of ACLs [Linux 3.15]

This Linux kernel change "GFS2: return -E2BIG if hit the maximum limits of ACLs" is included in the Linux 3.15 release. This change is authored by Jie Liu <jeff.liu [at] oracle.com> on Tue Mar 4 11:28:39 2014 +0800. The commit for this change in Linux stable tree is f2113eb (patch).

GFS2: return -E2BIG if hit the maximum limits of ACLs

Return -E2BIG rather than -EINVAL if hit the maximum size limits of
ACLs, as the former errno is consistent with VFS xattr syscalls.

This is pointed out by Dave Chinner in previous discussion thread:
http://www.spinics.net/lists/linux-fsdevel/msg71125.html

Signed-off-by: Jie Liu <jeff.liu@oracle.com>
Signed-off-by: Steven Whitehouse <swhiteho@redhat.com>

There are 2 lines of Linux source code added/deleted in this change. Code changes to Linux kernel are as follows.

 fs/gfs2/acl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/gfs2/acl.c b/fs/gfs2/acl.c
index ba94566..9c59ebe 100644
--- a/fs/gfs2/acl.c
+++ b/fs/gfs2/acl.c
@@ -86,7 +86,7 @@ int gfs2_set_acl(struct inode *inode, struct posix_acl *acl, int type)
    BUG_ON(name == NULL);

    if (acl->a_count > GFS2_ACL_MAX_ENTRIES)
-       return -EINVAL;
+       return -E2BIG;

    if (type == ACL_TYPE_ACCESS) {
        umode_t mode = inode->i_mode;

Leave a Reply

Your email address will not be published. Required fields are marked *