xfs: remove redundant stat assignment in xfs_bulkstat_one_int [Linux 3.17]

This Linux kernel change "xfs: remove redundant stat assignment in xfs_bulkstat_one_int" is included in the Linux 3.17 release. This change is authored by Jie Liu <jeff.liu [at] oracle.com> on Thu Jul 24 11:33:28 2014 +1000. The commit for this change in Linux stable tree is 8fe6577 (patch).

xfs: remove redundant stat assignment in xfs_bulkstat_one_int

From: Jie Liu <jeff.liu@oracle.com>

Remove the redundant BULKSTAT_RV_NOTHING assignment in case of call
xfs_iget() failed at xfs_bulkstat_one_int().

Signed-off-by: Jie Liu <jeff.liu@oracle.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Dave Chinner <david@fromorbit.com>

There are 5 lines of Linux source code added/deleted in this change. Code changes to Linux kernel are as follows.

 fs/xfs/xfs_itable.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/fs/xfs/xfs_itable.c b/fs/xfs/xfs_itable.c
index 7e54992..ca15214 100644
--- a/fs/xfs/xfs_itable.c
+++ b/fs/xfs/xfs_itable.c
@@ -76,10 +76,8 @@
    error = xfs_iget(mp, NULL, ino,
             (XFS_IGET_DONTCACHE | XFS_IGET_UNTRUSTED),
             XFS_ILOCK_SHARED, &ip);
-   if (error) {
-       *stat = BULKSTAT_RV_NOTHING;
+   if (error)
        goto out_free;
-   }

    ASSERT(ip != NULL);
    ASSERT(ip->i_imap.im_blkno != 0);
@@ -136,7 +134,6 @@
    IRELE(ip);

    error = formatter(buffer, ubsize, ubused, buf);
-
    if (!error)
        *stat = BULKSTAT_RV_DIDONE;

Leave a Reply

Your email address will not be published. Required fields are marked *