qlcnic: Avoid potential NULL pointer dereference

This change “qlcnic: Avoid potential NULL pointer dereference” (commit 5bf7295) in Linux kernel is authored by Aditya Pakki <pakki001 [at] umn.edu> on Thu Mar 14 15:31:40 2019 -0500.

Description of "qlcnic: Avoid potential NULL pointer dereference"

The change “qlcnic: Avoid potential NULL pointer dereference” introduces changes as follows.

qlcnic: Avoid potential NULL pointer dereference

netdev_alloc_skb can fail and return a NULL pointer which is
dereferenced without a check. The patch avoids such a scenario.

Signed-off-by: Aditya Pakki <pakki001@umn.edu>
Signed-off-by: David S. Miller <davem@davemloft.net>

Linux kernel releases containing commit 5bf7295

Linux kernel code changes from "qlcnic: Avoid potential NULL pointer dereference"

There are 2 lines of Linux source code added/deleted in this change. Code changes to Linux kernel are as follows.

 drivers/net/ethernet/qlogic/qlcnic/qlcnic_ethtool.c | 2 ++
 1 file changed, 2 insertions(+)
 
diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_ethtool.c b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_ethtool.c
index 3b0adda7cc9c..a4cd6f2cfb86 100644
--- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_ethtool.c
+++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_ethtool.c
@@ -1048,6 +1048,8 @@ int qlcnic_do_lb_test(struct qlcnic_adapter *adapter, u8 mode)
 
 	for (i = 0; i < QLCNIC_NUM_ILB_PKT; i++) {
 		skb = netdev_alloc_skb(adapter->netdev, QLCNIC_ILB_PKT_SIZE);
+		if (!skb)
+			break;
 		qlcnic_create_loopback_buff(skb->data, adapter->mac_addr);
 		skb_put(skb, QLCNIC_ILB_PKT_SIZE);
 		adapter->ahw->diag_cnt = 0;

The commit for this change in Linux stable tree is 5bf7295 (patch).

Last modified: 2020/02/09