net/mlx5e: Fix wrong private flag usage causing checksum disable [Linux 5.0]

This Linux kernel change "net/mlx5e: Fix wrong private flag usage causing checksum disable" is included in the Linux 5.0 release. This change is authored by Shay Agroskin <shayag [at] mellanox.com> on Sun Jan 6 17:55:59 2019 +0200. The commit for this change in Linux stable tree is 92b3277 (patch).

net/mlx5e: Fix wrong private flag usage causing checksum disable

MLX5E_PFLAG_* definitions were changed from bitmask to enumerated
values. However, in mlx5e_open_rq(), the proper API (MLX5E_GET_PFLAG macro)
was not used to read the flag value of MLX5E_PFLAG_RX_NO_CSUM_COMPLETE.
Fixed it.

Fixes: 8ff57c18e9f6 ("net/mlx5e: Improve ethtool private-flags code structure")
Signed-off-by: Shay Agroskin <[email protected]>
Reviewed-by: Tariq Toukan <[email protected]>
Signed-off-by: Saeed Mahameed <[email protected]>

There are 2 lines of Linux source code added/deleted in this change. Code changes to Linux kernel are as follows.

 drivers/net/ethernet/mellanox/mlx5/core/en_main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_main.c b/drivers/net/ethernet/mellanox/mlx5/core/en_main.c
index 8cfd2ec..01819e5 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/en_main.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/en_main.c
@@ -950,7 +950,7 @@ static int mlx5e_open_rq(struct mlx5e_channel *c,
    if (params->rx_dim_enabled)
        __set_bit(MLX5E_RQ_STATE_AM, &c->rq.state);

-   if (params->pflags & MLX5E_PFLAG_RX_NO_CSUM_COMPLETE)
+   if (MLX5E_GET_PFLAG(params, MLX5E_PFLAG_RX_NO_CSUM_COMPLETE))
        __set_bit(MLX5E_RQ_STATE_NO_CSUM_COMPLETE, &c->rq.state);

    return 0;

Leave a Reply

Your email address will not be published. Required fields are marked *