r8152: Fix an error on RTL8153-BD MAC Address Passthrough support [Linux 5.0]

r8152: Fix an error on RTL8153-BD MAC Address Passthrough support [Linux 5.0]

This Linux kernel change "r8152: Fix an error on RTL8153-BD MAC Address Passthrough support" is included in the Linux 5.0 release. This change is authored by David Chen <david.chen7 [at] dell.com> on Wed Feb 20 13:47:19 2019 +0800. The commit for this change in Linux stable tree is c286909 (patch).

r8152: Fix an error on RTL8153-BD MAC Address Passthrough support

RTL8153-BD is used in Dell DA300 type-C dongle.
Added RTL8153-BD support to activate MAC address pass through on DA300.
Apply correction on previously submitted patch in net.git tree.

Signed-off-by: David Chen <[email protected]>
Signed-off-by: David S. Miller <[email protected]>

There are 2 lines of Linux source code added/deleted in this change. Code changes to Linux kernel are as follows.

 drivers/net/usb/r8152.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c
index ada6baf..86c8c64 100644
--- a/drivers/net/usb/r8152.c
+++ b/drivers/net/usb/r8152.c
@@ -1179,7 +1179,7 @@ static int vendor_mac_passthru_addr_read(struct r8152 *tp, struct sockaddr *sa)
    } else {
        /* test for RTL8153-BND and RTL8153-BD */
        ocp_data = ocp_read_byte(tp, MCU_TYPE_USB, USB_MISC_1);
-       if ((ocp_data & BND_MASK) == 0 && (ocp_data & BD_MASK)) {
+       if ((ocp_data & BND_MASK) == 0 && (ocp_data & BD_MASK) == 0) {
            netif_dbg(tp, probe, tp->netdev,
                  "Invalid variant for MAC pass through\n");
            return -ENODEV;

Leave a Reply

Your email address will not be published. Required fields are marked *