tmpfs: fix uninitialized return value in shmem_link [Linux 5.0]

tmpfs: fix uninitialized return value in shmem_link [Linux 5.0]

This Linux kernel change "tmpfs: fix uninitialized return value in shmem_link" is included in the Linux 5.0 release. This change is authored by Darrick J. Wong <darrick.wong [at]> on Fri Feb 22 22:35:32 2019 -0800. The commit for this change in Linux stable tree is 29b00e6 (patch).

tmpfs: fix uninitialized return value in shmem_link

When we made the shmem_reserve_inode call in shmem_link conditional, we
forgot to update the declaration for ret so that it always has a known
value.  Dan Carpenter pointed out this deficiency in the original patch.

Fixes: 1062af920c07 ("tmpfs: fix link accounting when a tmpfile is linked in")
Reported-by: Dan Carpenter <[email protected]>
Signed-off-by: Darrick J. Wong <[email protected]>
Signed-off-by: Hugh Dickins <[email protected]>
Cc: Matej Kupljen <[email protected]>
Cc: Al Viro <[email protected]>
Cc: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>

There are 2 lines of Linux source code added/deleted in this change. Code changes to Linux kernel are as follows.

 mm/shmem.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/shmem.c b/mm/shmem.c
index 0905215..2c012ee 100644
--- a/mm/shmem.c
+++ b/mm/shmem.c
@@ -2848,7 +2848,7 @@ static int shmem_create(struct inode *dir, struct dentry *dentry, umode_t mode,
 static int shmem_link(struct dentry *old_dentry, struct inode *dir, struct dentry *dentry)
    struct inode *inode = d_inode(old_dentry);
-   int ret;
+   int ret = 0;

     * No ordinary (disk based) filesystem counts links as inodes;

Leave a Reply

Your email address will not be published. Required fields are marked *