clk: imx6q: fix refcount leak in imx6q_clocks_init() [Linux 5.1]

clk: imx6q: fix refcount leak in imx6q_clocks_init() [Linux 5.1]

This Linux kernel change "clk: imx6q: fix refcount leak in imx6q_clocks_init()" is included in the Linux 5.1 release. This change is authored by Yangtao Li <tiny.windzz [at] gmail.com> on Wed Dec 26 08:53:00 2018 -0500. The commit for this change in Linux stable tree is c9ec1d8 (patch).

clk: imx6q: fix refcount leak in imx6q_clocks_init()

The of_find_compatible_node() returns a node pointer with refcount
incremented, but there is the lack of use of the of_node_put() when
done. Add the missing of_node_put() to release the refcount.

Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
Fixes: 2acd1b6f889c ("ARM: i.MX6: implement clocks using common clock framework")
Signed-off-by: Stephen Boyd <sboyd@kernel.org>

There is one line of Linux source code added/deleted in this change. Code changes to Linux kernel are as follows.

 drivers/clk/imx/clk-imx6q.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/clk/imx/clk-imx6q.c b/drivers/clk/imx/clk-imx6q.c
index bbe0c60..53617e0 100644
--- a/drivers/clk/imx/clk-imx6q.c
+++ b/drivers/clk/imx/clk-imx6q.c
@@ -424,6 +424,7 @@ static void __init imx6q_clocks_init(struct device_node *ccm_node)
    np = of_find_compatible_node(NULL, NULL, "fsl,imx6q-anatop");
    anatop_base = base = of_iomap(np, 0);
    WARN_ON(!base);
+   of_node_put(np);

    /* Audio/video PLL post dividers do not work on i.MX6q revision 1.0 */
    if (clk_on_imx6q() && imx_get_soc_revision() == IMX_CHIP_REVISION_1_0) {

Leave a Reply

Your email address will not be published. Required fields are marked *