ASoC: simple-card: Fix missing of_node_put() at simple_dai_link_of() [Linux 5.1]

ASoC: simple-card: Fix missing of_node_put() at simple_dai_link_of() [Linux 5.1]

This Linux kernel change "ASoC: simple-card: Fix missing of_node_put() at simple_dai_link_of()" is included in the Linux 5.1 release. This change is authored by Takashi Iwai <tiwai [at] suse.de> on Tue Feb 19 16:46:48 2019 +0100. The commit for this change in Linux stable tree is 44662f9 (patch).

ASoC: simple-card: Fix missing of_node_put() at simple_dai_link_of()

We forgot to unreference the platform node object obtained from
of_get_child_by_name().  This leads to the unbalance of node
refcount.

Fixes: e0ae225b7e96 ("ASoC: simple-card: support platform in dts parse")
Signed-off-by: Takashi Iwai <[email protected]>
Acked-by: Kuninori Morimoto <[email protected]>
Signed-off-by: Mark Brown <[email protected]>

There is one line of Linux source code added/deleted in this change. Code changes to Linux kernel are as follows.

 sound/soc/generic/simple-card.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sound/soc/generic/simple-card.c b/sound/soc/generic/simple-card.c
index dc18c44..092963e 100644
--- a/sound/soc/generic/simple-card.c
+++ b/sound/soc/generic/simple-card.c
@@ -421,6 +421,7 @@ static int simple_dai_link_of(struct simple_priv *priv,
    asoc_simple_card_canonicalize_platform(dai_link);

 dai_link_of_err:
+   of_node_put(plat);
    of_node_put(node);

    return ret;

Leave a Reply

Your email address will not be published. Required fields are marked *