ALSA: hda: Initialize power_state field properly [Linux 5.1]

ALSA: hda: Initialize power_state field properly [Linux 5.1]

This Linux kernel change "ALSA: hda: Initialize power_state field properly" is included in the Linux 5.1 release. This change is authored by Takashi Iwai <tiwai [at] suse.de> on Sat Apr 13 10:04:49 2019 +0200. The commit for this change in Linux stable tree is 183ab39 (patch).

ALSA: hda: Initialize power_state field properly

The recent commit 98081ca62cba ("ALSA: hda - Record the current power
state before suspend/resume calls") made the HD-audio driver to store
the PM state in power_state field.  This forgot, however, the
initialization at power up.  Although the codec drivers usually don't
need to refer to this field in the normal operation, let's initialize
it properly for consistency.

Fixes: 98081ca62cba ("ALSA: hda - Record the current power state before suspend/resume calls")
Signed-off-by: Takashi Iwai <tiwai@suse.de>

There is one line of Linux source code added/deleted in this change. Code changes to Linux kernel are as follows.

 sound/pci/hda/hda_codec.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sound/pci/hda/hda_codec.c b/sound/pci/hda/hda_codec.c
index ec0b859..701a69d 100644
--- a/sound/pci/hda/hda_codec.c
+++ b/sound/pci/hda/hda_codec.c
@@ -969,6 +969,7 @@ int snd_hda_codec_device_new(struct hda_bus *bus, struct snd_card *card,

    /* power-up all before initialization */
    hda_set_power_state(codec, AC_PWRST_D0);
+   codec->core.dev.power.power_state = PMSG_ON;

    snd_hda_codec_proc_new(codec);

Leave a Reply

Your email address will not be published. Required fields are marked *