Input: synaptics-rmi4 – write config register values to the right offset [Linux 5.1]

Input: synaptics-rmi4 – write config register values to the right offset [Linux 5.1]

This Linux kernel change "Input: synaptics-rmi4 – write config register values to the right offset" is included in the Linux 5.1 release. This change is authored by Lucas Stach <l.stach [at] pengutronix.de> on Fri Apr 26 17:22:01 2019 -0700. The commit for this change in Linux stable tree is 3a34976 (patch).

Input: synaptics-rmi4 - write config register values to the right offset

Currently any changed config register values don't take effect, as the
function to write them back is called with the wrong register offset.

Fixes: ff8f83708b3e (Input: synaptics-rmi4 - add support for 2D
                     sensors and F11)
Signed-off-by: Lucas Stach <[email protected]>
Reviewed-by: Philipp Zabel <[email protected]>
Cc: [email protected]
Signed-off-by: Dmitry Torokhov <[email protected]>

There are 2 lines of Linux source code added/deleted in this change. Code changes to Linux kernel are as follows.

 drivers/input/rmi4/rmi_f11.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/input/rmi4/rmi_f11.c b/drivers/input/rmi4/rmi_f11.c
index df64d6a..93901eb 100644
--- a/drivers/input/rmi4/rmi_f11.c
+++ b/drivers/input/rmi4/rmi_f11.c
@@ -1230,7 +1230,7 @@ static int rmi_f11_initialize(struct rmi_function *fn)
    }

    rc = f11_write_control_regs(fn, &f11->sens_query,
-              &f11->dev_controls, fn->fd.query_base_addr);
+              &f11->dev_controls, fn->fd.control_base_addr);
    if (rc)
        dev_warn(&fn->dev, "Failed to write control registers\n");

Leave a Reply

Your email address will not be published. Required fields are marked *