bnxt_en: Free short FW command HWRM memory in error path in bnxt_init_one() [Linux 5.1]

bnxt_en: Free short FW command HWRM memory in error path in bnxt_init_one() [Linux 5.1]

This Linux kernel change "bnxt_en: Free short FW command HWRM memory in error path in bnxt_init_one()" is included in the Linux 5.1 release. This change is authored by Vasundhara Volam <vasundhara-v.volam [at] broadcom.com> on Thu Apr 25 22:31:51 2019 -0400. The commit for this change in Linux stable tree is f9099d6 (patch).

bnxt_en: Free short FW command HWRM memory in error path in bnxt_init_one()

In the bnxt_init_one() error path, short FW command request memory
is not freed. This patch fixes it.

Fixes: e605db801bde ("bnxt_en: Support for Short Firmware Message")
Signed-off-by: Vasundhara Volam <vasundhara-v.volam@broadcom.com>
Signed-off-by: Michael Chan <michael.chan@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

There is one line of Linux source code added/deleted in this change. Code changes to Linux kernel are as follows.

 drivers/net/ethernet/broadcom/bnxt/bnxt.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
index 42fd273..5d02f59 100644
--- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c
+++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
@@ -10692,6 +10692,7 @@ static int bnxt_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
    bnxt_clear_int_mode(bp);

 init_err_pci_clean:
+   bnxt_free_hwrm_short_cmd_req(bp);
    bnxt_free_hwrm_resources(bp);
    bnxt_free_ctx_mem(bp);
    kfree(bp->ctx);

Leave a Reply

Your email address will not be published. Required fields are marked *