libata: Extend quirks for the ST1000LM024 drives with NOLPM quirk [Linux 4.14.128]

libata: Extend quirks for the ST1000LM024 drives with NOLPM quirk [Linux 4.14.128]

This Linux kernel change "libata: Extend quirks for the ST1000LM024 drives with NOLPM quirk" is included in the Linux 4.14.128 release. This change is authored by Hans de Goede <hdegoede [at] redhat.com> on Tue Jun 11 16:32:59 2019 +0200. The commit for this change in Linux stable tree is 4156b5b (patch) which is from upstream commit 31f6264. The same Linux upstream change may have been applied to various maintained Linux releases and you can find all Linux releases containing changes from upstream 31f6264.

libata: Extend quirks for the ST1000LM024 drives with NOLPM quirk

commit 31f6264e225fb92cf6f4b63031424f20797c297d upstream.

We've received a bugreport that using LPM with ST1000LM024 drives leads
to system lockups. So it seems that these models are buggy in more then
1 way. Add NOLPM quirk to the existing quirks entry for BROKEN_FPDMA_AA.

BugLink: https://bugzilla.redhat.com/show_bug.cgi?id=1571330
Cc: stable@vger.kernel.org
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

There are 9 lines of Linux source code added/deleted in this change. Code changes to Linux kernel are as follows.

 drivers/ata/libata-core.c | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
index 04f406d..cbb162b 100644
--- a/drivers/ata/libata-core.c
+++ b/drivers/ata/libata-core.c
@@ -4472,9 +4472,12 @@ struct ata_blacklist_entry {
    { "ST3320[68]13AS", "SD1[5-9]", ATA_HORKAGE_NONCQ |
                        ATA_HORKAGE_FIRMWARE_WARN },

-   /* drives which fail FPDMA_AA activation (some may freeze afterwards) */
-   { "ST1000LM024 HN-M101MBB", "2AR10001", ATA_HORKAGE_BROKEN_FPDMA_AA },
-   { "ST1000LM024 HN-M101MBB", "2BA30001", ATA_HORKAGE_BROKEN_FPDMA_AA },
+   /* drives which fail FPDMA_AA activation (some may freeze afterwards)
+      the ST disks also have LPM issues */
+   { "ST1000LM024 HN-M101MBB", "2AR10001", ATA_HORKAGE_BROKEN_FPDMA_AA |
+                       ATA_HORKAGE_NOLPM, },
+   { "ST1000LM024 HN-M101MBB", "2BA30001", ATA_HORKAGE_BROKEN_FPDMA_AA |
+                       ATA_HORKAGE_NOLPM, },
    { "VB0250EAVER",    "HPG7",     ATA_HORKAGE_BROKEN_FPDMA_AA },

    /* Blacklist entries taken from Silicon Image 3124/3132

Leave a Reply

Your email address will not be published. Required fields are marked *