ipv6: Consider sk_bound_dev_if when binding a raw socket to an address [Linux 5.2]

ipv6: Consider sk_bound_dev_if when binding a raw socket to an address [Linux 5.2]

This Linux kernel change "ipv6: Consider sk_bound_dev_if when binding a raw socket to an address" is included in the Linux 5.2 release. This change is authored by Mike Manning <mmanning [at] vyatta.att-mail.com> on Mon May 20 19:57:17 2019 +0100. The commit for this change in Linux stable tree is 72f7cfa (patch).

ipv6: Consider sk_bound_dev_if when binding a raw socket to an address

IPv6 does not consider if the socket is bound to a device when binding
to an address. The result is that a socket can be bound to eth0 and
then bound to the address of eth1. If the device is a VRF, the result
is that a socket can only be bound to an address in the default VRF.

Resolve by considering the device if sk_bound_dev_if is set.

Signed-off-by: Mike Manning <[email protected]>
Reviewed-by: David Ahern <[email protected]>
Tested-by: David Ahern <[email protected]>
Signed-off-by: David S. Miller <[email protected]>

There are 2 lines of Linux source code added/deleted in this change. Code changes to Linux kernel are as follows.

 net/ipv6/raw.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/net/ipv6/raw.c b/net/ipv6/raw.c
index 84dbe21..96a3559 100644
--- a/net/ipv6/raw.c
+++ b/net/ipv6/raw.c
@@ -287,7 +287,9 @@ static int rawv6_bind(struct sock *sk, struct sockaddr *uaddr, int addr_len)
            /* Binding to link-local address requires an interface */
            if (!sk->sk_bound_dev_if)
                goto out_unlock;
+       }

+       if (sk->sk_bound_dev_if) {
            err = -ENODEV;
            dev = dev_get_by_index_rcu(sock_net(sk),
                           sk->sk_bound_dev_if);

Leave a Reply

Your email address will not be published. Required fields are marked *