ceph: fix buffer free while holding i_ceph_lock in __ceph_build_xattrs_blob() [Linux 4.19.72]

This Linux kernel change "ceph: fix buffer free while holding i_ceph_lock in __ceph_build_xattrs_blob()" is included in the Linux 4.19.72 release. This change is authored by Luis Henriques <lhenriques [at] suse.com> on Fri Jul 19 15:32:21 2019 +0100. The commit for this change in Linux stable tree is 5cd1e35 (patch) which is from upstream commit 12fe3dd. The same Linux upstream change may have been applied to various maintained Linux releases and you can find all Linux releases containing changes from upstream 12fe3dd.

ceph: fix buffer free while holding i_ceph_lock in __ceph_build_xattrs_blob()

[ Upstream commit 12fe3dda7ed89c95cc0ef7abc001ad1ad3e092f8 ]

Calling ceph_buffer_put() in __ceph_build_xattrs_blob() may result in
freeing the i_xattrs.blob buffer while holding the i_ceph_lock.  This can
be fixed by having this function returning the old blob buffer and have
the callers of this function freeing it when the lock is released.

The following backtrace was triggered by fstests generic/117.

  BUG: sleeping function called from invalid context at mm/vmalloc.c:2283
  in_atomic(): 1, irqs_disabled(): 0, pid: 649, name: fsstress
  4 locks held by fsstress/649:
   #0: 00000000a7478e7e (&type->s_umount_key#19){++++}, at: iterate_supers+0x77/0xf0
   #1: 00000000f8de1423 (&(&ci->i_ceph_lock)->rlock){+.+.}, at: ceph_check_caps+0x7b/0xc60
   #2: 00000000562f2b27 (&s->s_mutex){+.+.}, at: ceph_check_caps+0x3bd/0xc60
   #3: 00000000f83ce16a (&mdsc->snap_rwsem){++++}, at: ceph_check_caps+0x3ed/0xc60
  CPU: 1 PID: 649 Comm: fsstress Not tainted 5.2.0+ #439
  Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS rel-1.12.1-0-ga5cab58-prebuilt.qemu.org 04/01/2014
  Call Trace:
   dump_stack+0x67/0x90
   ___might_sleep.cold+0x9f/0xb1
   vfree+0x4b/0x60
   ceph_buffer_release+0x1b/0x60
   __ceph_build_xattrs_blob+0x12b/0x170
   __send_cap+0x302/0x540
   ? __lock_acquire+0x23c/0x1e40
   ? __mark_caps_flushing+0x15c/0x280
   ? _raw_spin_unlock+0x24/0x30
   ceph_check_caps+0x5f0/0xc60
   ceph_flush_dirty_caps+0x7c/0x150
   ? __ia32_sys_fdatasync+0x20/0x20
   ceph_sync_fs+0x5a/0x130
   iterate_supers+0x8f/0xf0
   ksys_sync+0x4f/0xb0
   __ia32_sys_sync+0xa/0x10
   do_syscall_64+0x50/0x1c0
   entry_SYSCALL_64_after_hwframe+0x49/0xbe
  RIP: 0033:0x7fc6409ab617

Signed-off-by: Luis Henriques <lhenriques@suse.com>
Reviewed-by: Jeff Layton <jlayton@kernel.org>
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>

There are 22 lines of Linux source code added/deleted in this change. Code changes to Linux kernel are as follows.

 fs/ceph/caps.c  |  5 ++++-
 fs/ceph/snap.c  |  4 +++-
 fs/ceph/super.h |  2 +-
 fs/ceph/xattr.c | 11 ++++++++---
 4 files changed, 16 insertions(+), 6 deletions(-)

diff --git a/fs/ceph/caps.c b/fs/ceph/caps.c
index a11fa0b..db547af 100644
--- a/fs/ceph/caps.c
+++ b/fs/ceph/caps.c
@@ -1280,6 +1280,7 @@ static int __send_cap(struct ceph_mds_client *mdsc, struct ceph_cap *cap,
 {
    struct ceph_inode_info *ci = cap->ci;
    struct inode *inode = &ci->vfs_inode;
+   struct ceph_buffer *old_blob = NULL;
    struct cap_msg_args arg;
    int held, revoking;
    int wake = 0;
@@ -1344,7 +1345,7 @@ static int __send_cap(struct ceph_mds_client *mdsc, struct ceph_cap *cap,
    ci->i_requested_max_size = arg.max_size;

    if (flushing & CEPH_CAP_XATTR_EXCL) {
-       __ceph_build_xattrs_blob(ci);
+       old_blob = __ceph_build_xattrs_blob(ci);
        arg.xattr_version = ci->i_xattrs.version;
        arg.xattr_buf = ci->i_xattrs.blob;
    } else {
@@ -1379,6 +1380,8 @@ static int __send_cap(struct ceph_mds_client *mdsc, struct ceph_cap *cap,

    spin_unlock(&ci->i_ceph_lock);

+   ceph_buffer_put(old_blob);
+
    ret = send_cap_msg(&arg);
    if (ret < 0) {
        dout("error sending cap msg, must requeue %p\n", inode);
diff --git a/fs/ceph/snap.c b/fs/ceph/snap.c
index 1f46b02..5cf7b5f 100644
--- a/fs/ceph/snap.c
+++ b/fs/ceph/snap.c
@@ -460,6 +460,7 @@ void ceph_queue_cap_snap(struct ceph_inode_info *ci)
    struct inode *inode = &ci->vfs_inode;
    struct ceph_cap_snap *capsnap;
    struct ceph_snap_context *old_snapc, *new_snapc;
+   struct ceph_buffer *old_blob = NULL;
    int used, dirty;

    capsnap = kzalloc(sizeof(*capsnap), GFP_NOFS);
@@ -536,7 +537,7 @@ void ceph_queue_cap_snap(struct ceph_inode_info *ci)
    capsnap->gid = inode->i_gid;

    if (dirty & CEPH_CAP_XATTR_EXCL) {
-       __ceph_build_xattrs_blob(ci);
+       old_blob = __ceph_build_xattrs_blob(ci);
        capsnap->xattr_blob =
            ceph_buffer_get(ci->i_xattrs.blob);
        capsnap->xattr_version = ci->i_xattrs.version;
@@ -579,6 +580,7 @@ void ceph_queue_cap_snap(struct ceph_inode_info *ci)
    }
    spin_unlock(&ci->i_ceph_lock);

+   ceph_buffer_put(old_blob);
    kfree(capsnap);
    ceph_put_snap_context(old_snapc);
 }
diff --git a/fs/ceph/super.h b/fs/ceph/super.h
index d8579a5..0180193 100644
--- a/fs/ceph/super.h
+++ b/fs/ceph/super.h
@@ -896,7 +896,7 @@ extern int ceph_getattr(const struct path *path, struct kstat *stat,
 int __ceph_setxattr(struct inode *, const char *, const void *, size_t, int);
 ssize_t __ceph_getxattr(struct inode *, const char *, void *, size_t);
 extern ssize_t ceph_listxattr(struct dentry *, char *, size_t);
-extern void __ceph_build_xattrs_blob(struct ceph_inode_info *ci);
+extern struct ceph_buffer *__ceph_build_xattrs_blob(struct ceph_inode_info *ci);
 extern void __ceph_destroy_xattrs(struct ceph_inode_info *ci);
 extern void __init ceph_xattr_init(void);
 extern void ceph_xattr_exit(void);
diff --git a/fs/ceph/xattr.c b/fs/ceph/xattr.c
index 71ea45b..5e4f3f8 100644
--- a/fs/ceph/xattr.c
+++ b/fs/ceph/xattr.c
@@ -734,12 +734,15 @@ static int __get_required_blob_size(struct ceph_inode_info *ci, int name_size,

 /*
  * If there are dirty xattrs, reencode xattrs into the prealloc_blob
- * and swap into place.
+ * and swap into place.  It returns the old i_xattrs.blob (or NULL) so
+ * that it can be freed by the caller as the i_ceph_lock is likely to be
+ * held.
  */
-void __ceph_build_xattrs_blob(struct ceph_inode_info *ci)
+struct ceph_buffer *__ceph_build_xattrs_blob(struct ceph_inode_info *ci)
 {
    struct rb_node *p;
    struct ceph_inode_xattr *xattr = NULL;
+   struct ceph_buffer *old_blob = NULL;
    void *dest;

    dout("__build_xattrs_blob %p\n", &ci->vfs_inode);
@@ -770,12 +773,14 @@ void __ceph_build_xattrs_blob(struct ceph_inode_info *ci)
            dest - ci->i_xattrs.prealloc_blob->vec.iov_base;

        if (ci->i_xattrs.blob)
-           ceph_buffer_put(ci->i_xattrs.blob);
+           old_blob = ci->i_xattrs.blob;
        ci->i_xattrs.blob = ci->i_xattrs.prealloc_blob;
        ci->i_xattrs.prealloc_blob = NULL;
        ci->i_xattrs.dirty = false;
        ci->i_xattrs.version++;
    }
+
+   return old_blob;
 }

 static inline int __get_request_mask(struct inode *in) {

Leave a Reply

Your email address will not be published. Required fields are marked *