r8169: silence sparse warning in rtl8169_start_xmit [Linux 5.3]

This Linux kernel change "r8169: silence sparse warning in rtl8169_start_xmit" is included in the Linux 5.3 release. This change is authored by Heiner Kallweit <hkallweit1 [at] gmail.com> on Thu Jun 6 07:49:17 2019 +0200. The commit for this change in Linux stable tree is 355f948 (patch).

r8169: silence sparse warning in rtl8169_start_xmit

The opts[] array is of type u32. Therefore remove the wrong
cpu_to_le32(). The opts[] array members are converted to little endian
later when being assigned to the respective descriptor fields.

This is not a new issue, it just popped up due to r8169.c having
been renamed and more thoroughly checked. Due to the renaming
this patch applies to net-next only.

Reported-by: kbuild test robot <lkp@intel.com>
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

There are 2 lines of Linux source code added/deleted in this change. Code changes to Linux kernel are as follows.

 drivers/net/ethernet/realtek/r8169_main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/realtek/r8169_main.c b/drivers/net/ethernet/realtek/r8169_main.c
index d34cc85..8b7d45f 100644
--- a/drivers/net/ethernet/realtek/r8169_main.c
+++ b/drivers/net/ethernet/realtek/r8169_main.c
@@ -5621,7 +5621,7 @@ static netdev_tx_t rtl8169_start_xmit(struct sk_buff *skb,
    if (unlikely(le32_to_cpu(txd->opts1) & DescOwn))
        goto err_stop_0;

-   opts[1] = cpu_to_le32(rtl8169_tx_vlan_tag(skb));
+   opts[1] = rtl8169_tx_vlan_tag(skb);
    opts[0] = DescOwn;

    if (rtl_chip_supports_csum_v2(tp)) {

Leave a Reply

Your email address will not be published. Required fields are marked *