staging: rtl8723bs: hal: Remove True/False Comparisons [Linux 5.3]

This Linux kernel change "staging: rtl8723bs: hal: Remove True/False Comparisons" is included in the Linux 5.3 release. This change is authored by Shobhit Kukreti <shobhitkukreti [at] gmail.com> on Tue Jun 18 18:14:44 2019 -0700. The commit for this change in Linux stable tree is d47f4db (patch).

staging: rtl8723bs: hal: Remove True/False Comparisons

Removing comparisons to True/False in if statements.

Checkpatch reported:
CHECK: Using comparison to true is error prone

Signed-off-by: Shobhit Kukreti <shobhitkukreti@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

There are 8 lines of Linux source code added/deleted in this change. Code changes to Linux kernel are as follows.

 drivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.c b/drivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.c
index eb6e07e..8e4caee 100644
--- a/drivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.c
+++ b/drivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.c
@@ -1421,7 +1421,7 @@ static void halbtc8723b1ant_PsTdma(

    if (bTurnOn) {
-       if (pBtLinkInfo->bSlaveRole == true)
+       if (pBtLinkInfo->bSlaveRole)
            psTdmaByte4Val = psTdmaByte4Val | 0x1;  /* 0x778 = 0x1 at wifi slot (no blocking BT Low-Pri pkts) */

@@ -2337,9 +2337,9 @@ static void halbtc8723b1ant_ActionWifiConnected(PBTC_COEXIST pBtCoexist)
                    );
            }
        } else if (
-           (pCoexSta->bPanExist == false) &&
-           (pCoexSta->bA2dpExist == false) &&
-           (pCoexSta->bHidExist == false)
+           (!pCoexSta->bPanExist) &&
+           (!pCoexSta->bA2dpExist) &&
+           (!pCoexSta->bHidExist)
        )
            halbtc8723b1ant_PowerSaveState(pBtCoexist, BTC_PS_WIFI_NATIVE, 0x0, 0x0);
        else

Leave a Reply

Your email address will not be published. Required fields are marked *