configfs: call fsnotify_rmdir() hook [Linux 5.3]

This Linux kernel change "configfs: call fsnotify_rmdir() hook" is included in the Linux 5.3 release. This change is authored by Amir Goldstein <amir73il [at] gmail.com> on Sun May 26 17:34:09 2019 +0300. The commit for this change in Linux stable tree is 6146e78 (patch).

configfs: call fsnotify_rmdir() hook

This will allow generating fsnotify delete events on unregister
of group/subsystem after the fsnotify_nameremove() hook is removed
from d_delete().

The rest of the d_delete() calls from this filesystem are either
called recursively from within debugfs_unregister_{group,subsystem},
called from a vfs function that already has delete hooks or are
called from shutdown/cleanup code.

Cc: Joel Becker <jlbec@evilplan.org>
Cc: Christoph Hellwig <hch@lst.de>
Signed-off-by: Amir Goldstein <amir73il@gmail.com>
Signed-off-by: Jan Kara <jack@suse.cz>

There are 3 lines of Linux source code added/deleted in this change. Code changes to Linux kernel are as follows.

 fs/configfs/dir.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/fs/configfs/dir.c b/fs/configfs/dir.c
index 5e7932d..ba17881 100644
--- a/fs/configfs/dir.c
+++ b/fs/configfs/dir.c
@@ -27,6 +27,7 @@
 #undef DEBUG

 #include <linux/fs.h>
+#include <linux/fsnotify.h>
 #include <linux/mount.h>
 #include <linux/module.h>
 #include <linux/slab.h>
@@ -1804,6 +1805,7 @@ void configfs_unregister_group(struct config_group *group)
    configfs_detach_group(&group->cg_item);
    d_inode(dentry)->i_flags |= S_DEAD;
    dont_mount(dentry);
+   fsnotify_rmdir(d_inode(parent), dentry);
    d_delete(dentry);
    inode_unlock(d_inode(parent));

@@ -1932,6 +1934,7 @@ void configfs_unregister_subsystem(struct configfs_subsystem *subsys)
    configfs_detach_group(&group->cg_item);
    d_inode(dentry)->i_flags |= S_DEAD;
    dont_mount(dentry);
+   fsnotify_rmdir(d_inode(root), dentry);
    inode_unlock(d_inode(dentry));

    d_delete(dentry);

Leave a Reply

Your email address will not be published. Required fields are marked *