EDAC/sb_edac: Remove redundant update of tad_base [Linux 5.3]

This Linux kernel change "EDAC/sb_edac: Remove redundant update of tad_base" is included in the Linux 5.3 release. This change is authored by Colin Ian King <colin.king [at] canonical.com> on Wed May 8 23:42:01 2019 +0100. The commit for this change in Linux stable tree is 0042e9e (patch).

EDAC/sb_edac: Remove redundant update of tad_base

The variable tad_base is being set to a value that is never read and is
being over-written on the next iteration of a for-loop. This assignment
is therefore redundant and can be removed.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Borislav Petkov <bp@suse.de>
Acked-by: Tony Luck <tony.luck@intel.com>
Cc: James Morse <james.morse@arm.com>
Cc: kernel-janitors@vger.kernel.org
Cc: linux-edac <linux-edac@vger.kernel.org>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: Qiuxu Zhuo <qiuxu.zhuo@intel.com>
Link: https://lkml.kernel.org/r/20190508224201.27120-1-colin.king@canonical.com

There is one line of Linux source code added/deleted in this change. Code changes to Linux kernel are as follows.

 drivers/edac/sb_edac.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/edac/sb_edac.c b/drivers/edac/sb_edac.c
index fa700a1..37746b0 100644
--- a/drivers/edac/sb_edac.c
+++ b/drivers/edac/sb_edac.c
@@ -1511,7 +1511,6 @@ static int knl_get_dimm_capacity(struct sbridge_pvt *pvt, u64 *mc_sizes)
                        sad_actual_size[mc] += tad_size;
                    }
                }
-               tad_base = tad_limit+1;
            }
        }

Leave a Reply

Your email address will not be published. Required fields are marked *