rtc: pcf8563: Fix interrupt trigger method [Linux 5.3]

This Linux kernel change "rtc: pcf8563: Fix interrupt trigger method" is included in the Linux 5.3 release. This change is authored by Chen-Yu Tsai <wens [at] csie.org> on Tue Jun 4 12:23:35 2019 +0800. The commit for this change in Linux stable tree is 65f662c (patch).

rtc: pcf8563: Fix interrupt trigger method

The PCF8563 datasheet says the interrupt line is active low and stays
active until the events are cleared, i.e. a level trigger interrupt.

Fix the flags used to request the interrupt.

Fixes: ede3e9d47cca ("drivers/rtc/rtc-pcf8563.c: add alarm support")
Signed-off-by: Chen-Yu Tsai <wens@csie.org>
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>

There are 2 lines of Linux source code added/deleted in this change. Code changes to Linux kernel are as follows.

 drivers/rtc/rtc-pcf8563.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/rtc/rtc-pcf8563.c b/drivers/rtc/rtc-pcf8563.c
index 3efc86c..e358313 100644
--- a/drivers/rtc/rtc-pcf8563.c
+++ b/drivers/rtc/rtc-pcf8563.c
@@ -605,7 +605,7 @@ static int pcf8563_probe(struct i2c_client *client,
    if (client->irq > 0) {
        err = devm_request_threaded_irq(&client->dev, client->irq,
                NULL, pcf8563_irq,
-               IRQF_SHARED|IRQF_ONESHOT|IRQF_TRIGGER_FALLING,
+               IRQF_SHARED | IRQF_ONESHOT | IRQF_TRIGGER_LOW,
                pcf8563_driver.driver.name, client);
        if (err) {
            dev_err(&client->dev, "unable to request IRQ %d\n",

Leave a Reply

Your email address will not be published. Required fields are marked *