ALSA: hda/hdmi - Read the pin sense from register when repolling

This change “ALSA: hda/hdmi - Read the pin sense from register when repolling” (commit 8c2e672) in Linux kernel is authored by Hui Wang <hui.wang [at] canonical.com> on Mon May 6 22:09:31 2019 +0800.

Description of "ALSA: hda/hdmi - Read the pin sense from register when repolling"

The change “ALSA: hda/hdmi - Read the pin sense from register when repolling” introduces changes as follows.

ALSA: hda/hdmi - Read the pin sense from register when repolling

The driver will check the monitor presence when resuming from suspend,
starting poll or interrupt triggers. In these 3 situations, the
jack_dirty will be set to 1 first, then the hda_jack.c reads the
pin_sense from register, after reading the register, the jack_dirty
will be set to 0. But hdmi_repoll_work() is enabled in these 3
situations, It will read the pin_sense a couple of times subsequently,
since the jack_dirty is 0 now, It does not read the register anymore,
instead it uses the shadow pin_sense which is read at the first time.

It is meaningless to check the shadow pin_sense a couple of times,
we need to read the register to check the real plugging state, so
we set the jack_dirty to 1 in the hdmi_repoll_work().

Signed-off-by: Hui Wang <hui.wang@canonical.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Takashi Iwai <tiwai@suse.de>

Linux kernel releases containing commit 8c2e672

Linux kernel code changes from "ALSA: hda/hdmi - Read the pin sense from register when repolling"

There are 5 lines of Linux source code added/deleted in this change. Code changes to Linux kernel are as follows.

 sound/pci/hda/patch_hdmi.c | 5 +++++
 1 file changed, 5 insertions(+)
 
diff --git a/sound/pci/hda/patch_hdmi.c b/sound/pci/hda/patch_hdmi.c
index 8b3ac690efa3..380001d6e797 100644
--- a/sound/pci/hda/patch_hdmi.c
+++ b/sound/pci/hda/patch_hdmi.c
@@ -1663,6 +1663,11 @@ static void hdmi_repoll_eld(struct work_struct *work)
 	container_of(to_delayed_work(work), struct hdmi_spec_per_pin, work);
 	struct hda_codec *codec = per_pin->codec;
 	struct hdmi_spec *spec = codec->spec;
+	struct hda_jack_tbl *jack;
+
+	jack = snd_hda_jack_tbl_get(codec, per_pin->pin_nid);
+	if (jack)
+		jack->jack_dirty = 1;
 
 	if (per_pin->repoll_count++ > 6)
 		per_pin->repoll_count = 0;

The commit for this change in Linux stable tree is 8c2e672 (patch).

Last modified: 2020/02/08