Action disabled: source

IB/mlx5: Fix RSS Toeplitz setup to be aligned with the HW specification

This change “IB/mlx5: Fix RSS Toeplitz setup to be aligned with the HW specification” (commit b7165bd) in Linux kernel is authored by Yishai Hadas <yishaih [at] mellanox.com> on Tue Jul 23 09:57:29 2019 +0300.

Description of "IB/mlx5: Fix RSS Toeplitz setup to be aligned with the HW specification"

The change “IB/mlx5: Fix RSS Toeplitz setup to be aligned with the HW specification” introduces changes as follows.

IB/mlx5: Fix RSS Toeplitz setup to be aligned with the HW specification

The specification for the Toeplitz function doesn't require to set the key
explicitly to be symmetric. In case a symmetric functionality is required
a symmetric key can be simply used.

Wrongly forcing the algorithm to symmetric causes the wrong packet
distribution and a performance degradation.

Link: https://lore.kernel.org/r/20190723065733.4899-7-leon@kernel.org
Cc: <stable@vger.kernel.org> # 4.7
Fixes: 28d6137008b2 ("IB/mlx5: Add RSS QP support")
Signed-off-by: Yishai Hadas <yishaih@mellanox.com>
Reviewed-by: Alex Vainman <alexv@mellanox.com>
Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>

Linux kernel releases containing commit b7165bd

The Linux kernel releases containing this commit are as follows.

Linux kernel code changes from "IB/mlx5: Fix RSS Toeplitz setup to be aligned with the HW specification"

There is one line of Linux source code added/deleted in this change. Code changes to Linux kernel are as follows.

 drivers/infiniband/hw/mlx5/qp.c | 1 -
 1 file changed, 1 deletion(-)
 
diff --git a/drivers/infiniband/hw/mlx5/qp.c b/drivers/infiniband/hw/mlx5/qp.c
index 615cc6771516..379328b2598f 100644
--- a/drivers/infiniband/hw/mlx5/qp.c
+++ b/drivers/infiniband/hw/mlx5/qp.c
@@ -1713,7 +1713,6 @@ static int create_rss_raw_qp_tir(struct mlx5_ib_dev *dev, struct mlx5_ib_qp *qp,
 		}
 
 		MLX5_SET(tirc, tirc, rx_hash_fn, MLX5_RX_HASH_FN_TOEPLITZ);
-		MLX5_SET(tirc, tirc, rx_hash_symmetric, 1);
 		memcpy(rss_key, ucmd.rx_hash_key, len);
 		break;
 	}

The commit for this change in Linux stable tree is b7165bd (patch).

Last modified: 2020/02/08