Linux Kernels

gpio: tc3589x: Use devm_gpiochip_add_data() for gpio registration

This change “gpio: tc3589x: Use devm_gpiochip_add_data() for gpio registration” (commit f3378b6) in Linux kernel is authored by Laxman Dewangan <ldewangan [at] nvidia.com> on Mon Feb 22 17:43:28 2016 +0530.

Description of "gpio: tc3589x: Use devm_gpiochip_add_data() for gpio registration"

The change “gpio: tc3589x: Use devm_gpiochip_add_data() for gpio registration” introduces changes as follows.

gpio: tc3589x: Use devm_gpiochip_add_data() for gpio registration

Use devm_gpiochip_add_data() for GPIO registration and remove the
need of driver callback .remove.

Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>

Linux kernel releases containing commit f3378b6

The Linux kernel releases containing this commit are as follows.

Linux kernel code changes from "gpio: tc3589x: Use devm_gpiochip_add_data() for gpio registration"

There are 13 lines of Linux source code added/deleted in this change. Code changes to Linux kernel are as follows.

 drivers/gpio/gpio-tc3589x.c | 13 ++-----------
 1 file changed, 2 insertions(+), 11 deletions(-)
 
diff --git a/drivers/gpio/gpio-tc3589x.c b/drivers/gpio/gpio-tc3589x.c
index 05a27ec55add..4f566e6b81f1 100644
--- a/drivers/gpio/gpio-tc3589x.c
+++ b/drivers/gpio/gpio-tc3589x.c
@@ -272,7 +272,8 @@ static int tc3589x_gpio_probe(struct platform_device *pdev)
 		return ret;
 	}
 
-	ret = gpiochip_add_data(&tc3589x_gpio->chip, tc3589x_gpio);
+	ret = devm_gpiochip_add_data(&pdev->dev, &tc3589x_gpio->chip,
+				     tc3589x_gpio);
 	if (ret) {
 		dev_err(&pdev->dev, "unable to add gpiochip: %d\n", ret);
 		return ret;
@@ -299,20 +300,10 @@ static int tc3589x_gpio_probe(struct platform_device *pdev)
 	return 0;
 }
 
-static int tc3589x_gpio_remove(struct platform_device *pdev)
-{
-	struct tc3589x_gpio *tc3589x_gpio = platform_get_drvdata(pdev);
-
-	gpiochip_remove(&tc3589x_gpio->chip);
-
-	return 0;
-}
-
 static struct platform_driver tc3589x_gpio_driver = {
 	.driver.name	= "tc3589x-gpio",
 	.driver.owner	= THIS_MODULE,
 	.probe		= tc3589x_gpio_probe,
-	.remove		= tc3589x_gpio_remove,
 };
 
 static int __init tc3589x_gpio_init(void)

The commit for this change in Linux stable tree is f3378b6 (patch).

Last modified: 2020/01/11 06:56