clk: sunxi: fix handling return value of of_property_match_string

This change “clk: sunxi: fix handling return value of of_property_match_string” (commit fee3103) in Linux kernel is authored by Andrzej Hajda <a.hajda [at] samsung.com> on Mon Dec 14 11:06:00 2015 +0100.

Description of "clk: sunxi: fix handling return value of of_property_match_string"

The change “clk: sunxi: fix handling return value of of_property_match_string” introduces changes as follows.

clk: sunxi: fix handling return value of of_property_match_string

The function can return negative values, so its result should
be assigned to signed variable.

The problem has been detected using proposed semantic patch
scripts/coccinelle/tests/assign_signed_to_unsigned.cocci [1].

[1]: http://permalink.gmane.org/gmane.linux.kernel/2046107

Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>

Linux kernel releases containing commit fee3103

The Linux kernel releases containing this commit are as follows.

Linux kernel code changes from "clk: sunxi: fix handling return value of of_property_match_string"

There are 8 lines of Linux source code added/deleted in this change. Code changes to Linux kernel are as follows.

 drivers/clk/sunxi/clk-sun8i-bus-gates.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
 
diff --git a/drivers/clk/sunxi/clk-sun8i-bus-gates.c b/drivers/clk/sunxi/clk-sun8i-bus-gates.c
index b8c775324a5c..e32d18ba252b 100644
--- a/drivers/clk/sunxi/clk-sun8i-bus-gates.c
+++ b/drivers/clk/sunxi/clk-sun8i-bus-gates.c
@@ -47,12 +47,12 @@ static void __init sun8i_h3_bus_gates_init(struct device_node *node)
 		return;
 
 	for (i = 0; i < ARRAY_SIZE(names); i++) {
-		index = of_property_match_string(node, "clock-names",
-						 names[i]);
-		if (index < 0)
+		int idx = of_property_match_string(node, "clock-names",
+						   names[i]);
+		if (idx < 0)
 			return;
 
-		parents[i] = of_clk_get_parent_name(node, index);
+		parents[i] = of_clk_get_parent_name(node, idx);
 	}
 
 	clk_data = kmalloc(sizeof(struct clk_onecell_data), GFP_KERNEL);

The commit for this change in Linux stable tree is fee3103 (patch).

Last modified: 2020/02/09